Re: [PATCH] fix inode_table test in ext234_check_descriptors

[Eric Sandeen]

Eric Sandeen wrote:
> ext[234]_check_descriptors sanity checks block group descriptor geometry
> at mount time, testing whether the block bitmap, inode bitmap, and
> inode table reside wholly within the blockgroup.  However, the inode
> table test is off by one so that if the last block in the inode table
> resides on the last block of the block group, the test incorrectly 
> fails.  This is because it tests the last block as (start + length)
> rather than (start + length - 1).
> 
> This can be seen by trying to mount a filesystem made such as:
>  mkfs.ext2 -F -b 1024 -m 0 -g 256 -N 3744 fsfile 1024
> which yields:
>  EXT2-fs error (device loop0): ext2_check_descriptors: Inode table for group 0 not in group (block 101)!
>  EXT2-fs: group descriptors corrupted!

Hm, sorry, after seeing Miklos' last patches... should I be sending
these as 3 different patches for ext2, 3, and 4...?

-Eric (who really doesn't want to make Andrew mad at him)  :)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/