[PATCH] [2.6.22] Fix a potential NULL pointer dereference in mace_interrupt()in drivers/net/pcmcia/nmclan_cs.c

[Micah Gruber]

This patch fixes a potential null dereference bug where we dereference 
DEV before a null check. This patch simply moves the dereferencing after 
the null check.

Signed-off-by: Micah Gruber <micah.gruber@xxxxxxxxx>

---

--- a/drivers/net/pcmcia/nmclan_cs.c    
+++ b/drivers/net/pcmcia/nmclan_cs.c    
@@ -996,7 +996,7 @@
{
  struct net_device *dev = (struct net_device *) dev_id;
  mace_private *lp = netdev_priv(dev);
-  kio_addr_t ioaddr = dev->base_addr;
+  kio_addr_t ioaddr;
  int status;
  int IntrCnt = MACE_MAX_IR_ITERATIONS;

@@ -1006,6 +1006,8 @@
    return IRQ_NONE;
  }

+  ioaddr = dev->base_addr;
+
  if (lp->tx_irq_disabled) {
    printk(
      (lp->tx_irq_disabled?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/