Re: [Patch 02/16] Remove unnecessary kmalloc casts from the mipsarch.

From: Rene Herman
Date: Tue Jul 31 2007 - 11:18:34 EST


On 07/31/2007 02:53 PM, jack@xxxxxxxxxxxxxxxxxxxxxxx wrote:

- desc_base = (u32)kmalloc(entries * sizeof(au1x_ddma_desc_t),
+ desc_base = kmalloc(entries * sizeof(au1x_ddma_desc_t),

The unnessary bit in kmalloc casts is due to void pointers being assignment compatible to other pointer types but in these patches you are also removing casts to unsigned long's and they should stay.

I noticed the same in patch 2, 4, 6, 8, 9 and 11 (cursory glance...)

Rene.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/