Re: [PATCH] Change paride driver to use unlocked_ioctl instead ofioctl

[Jiri Kosina]

On Wed, 9 Jan 2008, Matthew Wilcox wrote:

> >  	default:
> >  		printk("%s: Unimplemented ioctl 0x%x\n", tape->name, cmd);
> > +		unlock_kernel();
> >  		return -EINVAL;
> Surely a bug ... shouldn't this return -ENOTTY?

What POSIX states [1]:

[EINVAL]
    The request or arg argument is not valid for this device.

[ENOTTY]
    The fildes argument is not associated with a STREAMS device that
    accepts control functions.

[1] http://www.opengroup.org/onlinepubs/009695399/functions/ioctl.html

-- 
Jiri Kosina
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/