Re: [PATCH] Change paride driver to use unlocked_ioctl instead ofioctl

From: Alan Cox
Date: Wed Jan 09 2008 - 11:59:22 EST


On Wed, 9 Jan 2008 14:26:26 +0100 (CET)
Jiri Kosina <jikos@xxxxxxxx> wrote:

> On Wed, 9 Jan 2008, Matthew Wilcox wrote:
>
> > > default:
> > > printk("%s: Unimplemented ioctl 0x%x\n", tape->name, cmd);
> > > + unlock_kernel();
> > > return -EINVAL;
> > Surely a bug ... shouldn't this return -ENOTTY?

Agreed - ENOTTY. The printk is wrong as well, but this is just getting
shown up by the other changes.

Does anyone even use parallel IDE devices any more ?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/