Re: [PATCH 5/6] Driver for WM97xx touchscreens in streaming modeon PXA2xx systems

[Mark Brown]

On Mon, Jan 14, 2008 at 10:56:06AM +0100, Marc Kleine-Budde wrote:
> reMark Brown wrote:

> > Cc: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
>                                 ^^
> it's mkl@xxxxxxxxxxxxxx

Fixed, sorry about that.

> > +			/* use PEN_DOWN GPIO 13 to assert IRQ on GPIO line 2 */
> > +			wm->pen_irq = MAINSTONE_AC97_IRQ;

> I'm missing some kind of abstraction here, what about non mainstone
> boards with the pen irq wired to some other gpio?

The driver really isn't intended to cope with them.  As you say, other
boards may have things wired up differently and therefore require
different configuration of the wm97xx and other bits of the system.  The
expectation is that other systems will have their own driver.

My initial thought is that the most straightforward way of handling this
would be to rename the driver to mainstone-wm97xx or similar to make it
clear that the driver is only intended to handle Mainstone as-is.  Does
that seem reasonable?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/