Re: [PATCH 07/19] dlm: swap bytes for rcom lock reply

[Andrew Morton]

> On Thu, 24 Jan 2008 10:50:30 -0600 David Teigland <teigland@xxxxxxxxxx> wrote:
>  void dlm_rcom_in(struct dlm_rcom *rc)
>  {
>  	struct dlm_header *hd = (struct dlm_header *) rc;

aww, c'mon guys, this is nonsense.

	struct dlm_header *hd = &rc->rc_header;

there seems to be rather a lot of this unnecessary casting going on in dlm. 
Please do a hunt-and-exterminate.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/