Re: [PATCH 07/19] dlm: swap bytes for rcom lock reply

[David Teigland]

On Sat, Jan 26, 2008 at 10:00:29PM -0800, Andrew Morton wrote:
> > On Thu, 24 Jan 2008 10:50:30 -0600 David Teigland <teigland@xxxxxxxxxx> wrote:
> >  void dlm_rcom_in(struct dlm_rcom *rc)
> >  {
> >  	struct dlm_header *hd = (struct dlm_header *) rc;
> 
> aww, c'mon guys, this is nonsense.
> 
> 	struct dlm_header *hd = &rc->rc_header;
> 
> there seems to be rather a lot of this unnecessary casting going on in dlm. 
> Please do a hunt-and-exterminate.

Yes, there's a fair bit of that kind of cleanup I'd like to do.  I'll add
another cleanup-only patch to the series that at least makes a start on
it.  Thanks
Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/