Re: bug in checkpatch (on pointers to typedefs?)

From: Benny Halevy
Date: Tue Feb 12 2008 - 03:22:22 EST


On Feb. 11, 2008, 20:42 +0200, Andy Whitcroft <apw@xxxxxxxxxxxx> wrote:
> On Mon, Feb 11, 2008 at 06:58:08PM +0200, Benny Halevy wrote:
>> OK, but the return type doesn't have to be in the patched line, it could be in
>> a synchronization line or even missing if the function has a long multi-line argument
>> list.
>
> Ok, I guess thats fair criticism. Could you check out the current
> checkpatch-next (0.14-8-g3737366 or later -9, -10 etc), and see if
> that works. It seems to on the simple examples you sent me :).

Confirmed with 0.14-8-g3737366.

Thanks!

Benny

Oh, and I really liked the fact that you print the patch file name
in the summary line of each patch checked rather than "Your patch" :)

>
> Thanks.
>
> -apw

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/