Re: [PATCH 1/1] [SCSI] gdth: misc cleanups, preparation for ISA/EISAhotplug API

[Jeff Garzik]

Christoph Hellwig wrote:
> Eventually we shoud just kill the INT_COAL ifdefed code.  It has never
> been enabled and clutters up the driver quite badly.

Noted (queued)...  fine by me, and makes life easier.


> > +#ifdef CONFIG_EISA
> > +	if ((ha->type == GDT_EISA) && (ha->ccb_phys))
> > +		pci_unmap_single(ha->pdev, ha->ccb_phys, sizeof(gdth_cmd_str),
> > +				 PCI_DMA_BIDIRECTIONAL);
> > +#endif /* CONFIG_EISA */
>
> I don't think moving this into the common helper makes any sense, as
> it's only ever done for the eisa adapter.  Just keep it local there.
>
> > +#ifdef CONFIG_EISA
> > +	if (ha->type == GDT_EISA) {
> > +		ha->ccb_phys = pci_map_single(ha->pdev, &ha->cmdext,
> > +				sizeof(gdth_cmd_str), PCI_DMA_BIDIRECTIONAL);
> > +		if (!ha->ccb_phys)
> > +			goto out_free;
> > +	}
> > +#endif /* CONFIG_EISA */
>
> Same here.

hmmmmm.  We'll see how it plays out...  on the remove side, the above is 
exact what happens in gdth_remove_one() without my patch, thus 
consolidating two cases of the same code into one.  There is a 
less-strong argument for doing the allocation that way, but it may turn 
out to be useful anyway once the ISA/EISA API conversion is complete.

	Jeff


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/