Re: [(RT RFC) PATCH v2 2/9] sysctl for runtime-control of lateralmutex stealing
From: Pavel Machek
Date: Mon Feb 25 2008 - 18:00:04 EST
Hi!
> > > index c913d48..c24c53d 100644
> > > --- a/kernel/sysctl.c
> > > +++ b/kernel/sysctl.c
> > > @@ -175,6 +175,10 @@ extern struct ctl_table inotify_table[];
> > > int sysctl_legacy_va_layout;
> > > #endif
> > >
> > > +#ifdef CONFIG_RTLOCK_LATERAL_STEAL
> > > +extern int rtmutex_lateral_steal;
> > > +#endif
> > > +
> >
> > Try checkpatch.
>
> I have that as part of quilt refresh, and it returns:
>
> Your patch has no obvious style problems and is ready for
> submission.
Sorry. Anyway, there should not be externs in .c files, so
extern int rtmutex_lateral_steal;
should go to header file.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/