Re: 2.6.25-rc2 Regression Thinkpad acpi

[Henrique de Moraes Holschuh]

On Mon, 25 Feb 2008, Lukas Hejtmanek wrote:
> volume keys work. But anything through acpid does not. Even AC/battery switch
> is not signalized. So the bug may be somewhere else?

Yeah, there is an EC-related regression in 2.6.25-rc3 that bites your
thinkpad.  I don't have a link to it right now, but if you look for the
messages to LKML on the last 48h, you will find it.

> [  418.816087] thinkpad_acpi: requested hot key mask 0xffffffff, but firmware forced it to 0x00ffffff

Don't do this.  Just let the driver select the default mask, unless you
*really* know better.

> > Sure, try this one:
> 
> not better.

It wouldn't fix any EC issues.  If you just revert the
6c231bd5eb07ce546517019f334652b9ecfc329a commit entirely (note, I don't mean
revert TO THE COMMIT), by doing something like this:

git checkout v2.6.25-rc3
git show 6c231bd5eb07ce546517019f334652b9ecfc329a | patch -p1 -R

Does it fix anything ?

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/