Re: [PATCH 1/1] Speedfreq-SMI call clobbers ECX

From: Ingo Molnar
Date: Tue Mar 11 2008 - 05:39:35 EST



* Stephan Diestelhorst <langer_mann@xxxxxx> wrote:

> Please also note that these are not clobbers in the strict inline asm
> syntax, but rather dummy output values that correspond to actual input
> parameters. I'd consider this a serious compiler flaw, if not bug, if
> these would not work. But let's not get into GCC vs.
> Fancy-inline-asm-hacker flames, like the mplayer folks do ;-)

yep, that's my experience as well - output constraints are pretty robust
in general, but if one tries the same effect via the clobber list it's
easy to run into gcc internal errors. I've applied your patch to
x86.git. Do you think it's 2.6.25 material? I'm inclined to have it in
the 2.6.26 bucket. We could do your first, minimal fix in 2.6.25 and do
this second, full fix in 2.6.26.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/