Re: sparc64 BUG: using smp_processor_id() in preemptible

[David Miller]

From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Date: Wed, 26 Mar 2008 20:25:02 -0700

> On Wed, 26 Mar 2008 04:25:16 -0700 (PDT) David Miller <davem@xxxxxxxxxxxxx> wrote:
> 
> >  	preempt_disable();
> >  
> > +	mp = &__get_cpu_var(mmu_gathers);
> 
> that's an open-coded get_cpu_var().
> 
> fwiw.  Which isn't much, IMO.  Sometimes it's nice to see things open-coded.

Good point, I might restructure that to use {get,put}_cpu_var().
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/