Re: [PATCH 2/7] omfs: add inode routines

From: Andi Kleen
Date: Thu Mar 27 2008 - 02:14:06 EST


Bob Copeland <me@xxxxxxxxxxxxxxx> writes:
> +
> + bitmap_size = (sbi->s_num_blocks + 7) / 8;
> + array_size = (bitmap_size + sb->s_blocksize - 1) / sb->s_blocksize;
> +
> + sbi->s_imap_size = array_size;
> + sbi->s_imap = kzalloc(array_size * sizeof(unsigned long), GFP_KERNEL);


If the array can be really 300k you should probably have a vmalloc fallback
here.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/