Re: [v4l-dvb-maintainer] [PATCH] media: replace remaining __FUNCTION__ occurences

[Harvey Harrison]

On Wed, 2008-04-09 at 13:00 -0400, Michael Krufky wrote:
> On Fri, Apr 4, 2008 at 11:09 AM, Michael Krufky <mkrufky@xxxxxxxxxxx> 
> Harvey,
> 
> I have received your entire patchset.  Some patches have already been
> merged into our development tree, others have been dropped, since some
> of individual driver maintainers have decided to remove the
> __FUNCTION__ macro from their source code altogether, rather than
> accept this change.
> 
> I have merged the remaining pending patches into a mercurial tree,
> hosted on linuxtv.org:
> 
> http://linuxtv.org/hg/~mkrufky/function-func
> 
> Please note that I had to manually apply patches 8, 11 and 13, since
> you generated your changes against the git repository rather than the
> official v4l-dvb development repository hosted on linuxtv.org.

I don't know/use mercurial, sorry, I thought git-v4l's devel branch on
kernel.org would be a mirror of the development tree...guess I was
mistaken

> 
> I must stress this -- all v4l-dvb patches, ESPECIALLY
> codingstyle-cleanups (due to the nature of those patches, touching
> many many files at once), should always be generated against the
> v4l-dvb master development repository hosted on linuxtv.org.
> 
> Now, I have a question.....
> 
> About this change from __FUNCTION__ to __func__ , I understand that
> this change is being done kernel-wide.  At first, I had blindly
> accepted this change as a kernel-janitor "cleanup", until it was
> pointed out to me last night, that older compilers do not support
> __func__.  Sure, one can always do the following for compat:
> 
> #ifndef __func__
>  #define __func__ __FUNCTION__
> #endif /* __func__ */

This is already done in kernel.h, so __func__ is already being passed to
any compiler used on the kernel....

/* Trap pasters of __FUNCTION__ at compile-time */
#define __FUNCTION__ (__func__)

> 
> ...but the question is raised, why are we making this change in the first place?
> 
> Don't get me wrong -- as I said before, I understand that this change
> is kernel-wide, and I am not arguing against it.  I will continue on
> to have this merged into 2.6.26.  I would just like to see a link that
> points to a discussion thread on LKML that explains the reasons for
> this change, and where this change was globally agreed to.  Again -- I
> am not challenging these patches.  I merely want to read more
> information as to why we are making this move.
> 
> In the meanwhile, below is the checkpatch.pl fallout after applying
> your __FUNCTION__ to __func__ series.  Since you are working on these
> codingstyle cleanups anyway, I'd imagine that you won't mind fixing
> these checkpatch.pl "errors" and "warnings" before we merge these
> changes.

For such a large set in v4l, it's a drastic increase in work to do so
in this case as it is a simple sed s/__FUNCTION__/__func__/

> 
> I understand if you don't want to alter code that you may not be
> directly involved in, but I am sure you will have no trouble at least
> fixing the "comma after space" and "line over 80 characters" cases.
> 
> Please generate the additional cleanups against the mercurial tree
> that I merged your previous series to:
> 
> http://linuxtv.org/hg/~mkrufky/function-func

Do you have a git mirror somewhere?

> 
> Also, please generate the codingstyle cleanup patches individually
> based on the directory structure, just as you did in your last series.
> 
> See below for the checkpatch.pl "errors" and "warnings".

I can't say I have much enthusiasm for that, but if you'd really want
such a patch, I will try to get to it this week.


Harvey

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/