Re: [v4l-dvb-maintainer] [PATCH] media: replace remaining __FUNCTION__ occurences

[Mauro Carvalho Chehab]

On Wed, 09 Apr 2008 11:30:25 -0700
Harvey Harrison <harvey.harrison@xxxxxxxxx> wrote:

> For such a large set in v4l, it's a drastic increase in work to do so
> in this case as it is a simple sed s/__FUNCTION__/__func__/

I think the "sed" approach is the better, on this case. It avoids mistakes that
might be caused by manual changes of that amount of line changes.

> > I understand if you don't want to alter code that you may not be
> > directly involved in, but I am sure you will have no trouble at least
> > fixing the "comma after space" and "line over 80 characters" cases.
> > 
> > Please generate the additional cleanups against the mercurial tree
> > that I merged your previous series to:
> > 
> > http://linuxtv.org/hg/~mkrufky/function-func
> 
> Do you have a git mirror somewhere?

The V4L/DVB -git tree is at:
	http://www.kernel.org/git/?p=linux/kernel/git/mchehab/v4l-dvb.git

Also, linux-next is updated with the same patches applied on the above tree.

However, some manual adjustments may still be needed, since we have backward
compatibility code on Mercurial (to allow users to test V4L/DVB drivers on
older kernels).

At the -git, all those #if KERNEL_VERSION stuff that are inside Mercurial are
stripped.

Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/