Re: [patch] e1000=y && e1000e=m regression fix

[Matthew Wilcox]

On Fri, Apr 11, 2008 at 10:34:01AM -0700, Linus Torvalds wrote:
> Here's a suggested patch. Not much tested, but it's fairly obvious.
> 
> It basically makes one top-level config option (E1000) to pick the driver 
> at all, and two sub-options (E1000_PCI and E1000_PCIE) that you can choose 
> between.

I think it's a little over-engineered ... why not simply:

config E1000_SUPPORT
	bool "Intel(R) PRO/1000 Gigabit Ethernet support"
	depends on PCI

config E1000
	depends on E1000_SUPPORT
	tristate "E1000 PCI support"
	help
	  Include support for Conventional PCI devices.  This includes
	  chips built into motherboards ... blah blah, if unsure say "Y"
	  or "M"

config E1000E
	depends on E1000_SUPPORT
	tristate "E1000 PCI Express support"
	help
	  Include support for PCI Express devices.  This includes chips
	  built into motherboards such as ICH9 ... blah blah, if unsure
	  say "Y" or "M".

and get rid of the PCIE() macros from the e1000 driver.  While it does
allow someone like Ingo to create a E1000=y and E1000E=m situation
(which won't bind to an ethernet card that E1000 used to), having the
E1000_SUPPORT symbol means that oldconfig will stop and ask you which
hopefully makes it obvious enough that things have changed here and you
need to pay attention.

-- 
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/