Re: [patch] e1000=y && e1000e=m regression fix

[Linus Torvalds]

On Fri, 11 Apr 2008, Matthew Wilcox wrote:
> 
> I think it's a little over-engineered ... why not simply:

Because your version has exactly the same problem that the current code 
has: it asks questions that aren't sensible to people who don't care. It 
also keeps the old E1000 name for "PCI chips only", which means that 
people who just use an old config and ignore new questions will suddenly 
lose their ability to use the E1000 driver if they have a PCI-E card.

So most users:
 - want to just say "E1000", and not care about type.
 - want to have old configurations continue working (ie if you haev had 
   "E1000" driving your hardware before, it should _continue_ to do so, 
   with no need to select a _new_ E1000E question!

Nobody wants to care deeply whether it's a PCI-E or PCI chip. In fact, 
it's almost impossible to tell. Here, quickly, tell me which one mine is 
(this is from /sbin/lspci):

	00:19.0 Ethernet controller: Intel Corporation 82566DM Gigabit Network Connection (rev 02)

and tell me how you knew..

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/