Re: [patch] e1000=y && e1000e=m regression fix

[Matthew Wilcox]

On Fri, Apr 11, 2008 at 11:51:07AM -0700, Linus Torvalds wrote:
> Because your version has exactly the same problem that the current code 
> has: it asks questions that aren't sensible to people who don't care. It 
> also keeps the old E1000 name for "PCI chips only", which means that 
> people who just use an old config and ignore new questions will suddenly 
> lose their ability to use the E1000 driver if they have a PCI-E card.

We only support people keeping their old configs after they run 'make
oldconfig', right?  At which point they'd be prompted for E1000_SUPPORT.
Presumably they'd think "That's odd.  I'm sure I had that selected
before", then select it.  Then oldconfig skips over CONFIG_E1000 because
it already knows the answer to that one and they're prompted with a
question about PCIe support.  Now something is clearly strange.  Perhaps
they look at the help text at this point and it says to go with 'Y' or
'M' if they're not sure.

That's the most important bit of help texts for me.  Do I want Control
Groups?  Will my machine break if I don't select them?  I have no idea
what a 'process cgroup subsystem' is, and I don't care.  But the help
text tells me I can say "n" and nothing will break.

> So most users:
>  - want to just say "E1000", and not care about type.
>  - want to have old configurations continue working (ie if you haev had 
>    "E1000" driving your hardware before, it should _continue_ to do so, 
>    with no need to select a _new_ E1000E question!
> 
> Nobody wants to care deeply whether it's a PCI-E or PCI chip. In fact, 
> it's almost impossible to tell. Here, quickly, tell me which one mine is 
> (this is from /sbin/lspci):
> 
> 	00:19.0 Ethernet controller: Intel Corporation 82566DM Gigabit Network Connection (rev 02)

I quite agree.  I have no idea either.  All I know is that my ICH9 box
didn't work until e1000e was released ;-)

-- 
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/