Re: [PATCH 6/8] rfkill: add the WWAN radio type

[Dmitry Torokhov]

On Sun, Apr 13, 2008 at 03:16:21PM -0300, Henrique de Moraes Holschuh wrote:
> On Sun, 13 Apr 2008, Ivo van Doorn wrote:
> > On Sunday 13 April 2008, Henrique de Moraes Holschuh wrote:
> > > On Sat, 12 Apr 2008, Inaky Perez-Gonzalez wrote:
> > > > Most rfkill hw keys are attached to the device. So I can plug wifi, wimax,
> > > > 3G, UWB and BT dongles (or cards) into a system and they each provide a HW
> > > > switch (or should provide).
> > > > 
> > > > If each overrides another one, we have a problem.
> > > 
> > > Yeah, and we have to avoid such problems.
> > > 
> > > But let me ask you one thing.  Are we talking of different rfkill
> > > switches, OR are we talking about different KEYs or BUTTONS in the
> > > keyboard/keypad/console/remote control?
> > > 
> > > Because one thing has very little to do with the other.  No network
> > > device driver shall generate an input event after I am done with the
> > > next patch set...
> > 
> > Not sure if that will be the desired course of action.
> > The original rfkill function didn't work with input devices either and just
> > handled everything in rfkill.
> > But the input layer people requested the change to use input devices and let
> > rfkill hook into that, because a rfkill switch/key can be considered an input device.
> > 
> > I've CC'ed Dmitry into this discussion since he was the one who suggested the
> > input device interaction initialy (and created the rfkill-input module).
> 
> In order to avoid a lot of misunderstandings, we better name the
> "enable/disable radio apparatus" (the circuit/config register that
> causes a radio to disable its RF path) and the "input hardware rf-switch
> device" (the thing the user presses/moves) in different ways, at least
> when we are talking about them.
> 
> Right now both are usually called rfkill switch, and much of the mess
> comes from that...
> 
> "input hardware rf-switch devices" ARE input devices, belong to the
> input layer, and issue input events.
> 

Exactly. And some times they are completely separated from the RF switch
itself, in the same fashion some keyboards have sleep key that is not
directly wired into ACPI. That was the reason I wanted the radio control
and key/switch/sliter to be separated.

> "enable/disable radio apparatus" don't, and the input layer should not
> be abused as a "status reporting" feature for those.  We certainly will
> benefit from those issuing kernel notifications through a notification
> chain for them, though.
> 
> And many devices are both at the same time (e.g. a b43 in certain
> hardware configurations), and many drivers have both types (e.g.
> thinkpad-acpi's hotkey subsystem has "input hardare rf-switch devices"
> functions, and thinkpad-acpi's bluetooth firmware handling have
> "enable/disable radio apparatus" functions).
> 

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/