Re: [PATCH 1/8] rfkill: clarify meaning of rfkill states

From: Dmitry Torokhov
Date: Mon Apr 14 2008 - 00:22:49 EST


On Fri, Apr 11, 2008 at 05:37:17PM -0300, Henrique de Moraes Holschuh wrote:
> rfkill really should have been named rfswitch. As it is, one can get
> confused whether RFKILL_STATE_ON means the KILL switch is on (and
> therefore, the radio is being *blocked* from operating), or whether it
> means the RADIO rf output is on.
>
> Clearly state that RFKILL_STATE_ON means the radio is *unblocked* from
> operating (i.e. there is no rf killing going on).
>
> Signed-off-by: Henrique de Moraes Holschuh <hmh@xxxxxxxxxx>
> Cc: Ivo van Doorn <IvDoorn@xxxxxxxxx>
> Cc: John W. Linville <linville@xxxxxxxxxxxxx>
> Cc: Dmitry Torokhov <dtor@xxxxxxx>

I consider Ivo maintaining rfkill but for what it worth:

Acked-by: Dmitry Torokhov <dtor@xxxxxxx>

--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/