Re: [PATCH] smb.h: uses struct timespec but didn't include linux/time.h

[Ilpo Järvinen]

On Tue, 15 Apr 2008, Andrew Morton wrote:

> On Tue, 15 Apr 2008 12:04:04 +0300 (EEST) "Ilpo J__rvinen" <ilpo.jarvinen@xxxxxxxxxxx> wrote:
> 
> > 
> > Signed-off-by: Ilpo J__rvinen <ilpo.jarvinen@xxxxxxxxxxx>
> > ---
> >  include/linux/smb.h |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/include/linux/smb.h b/include/linux/smb.h
> > index f098dff..caa43b2 100644
> > --- a/include/linux/smb.h
> > +++ b/include/linux/smb.h
> > @@ -11,6 +11,7 @@
> >  
> >  #include <linux/types.h>
> >  #include <linux/magic.h>
> > +#include <linux/time.h>
> >  
> >  enum smb_protocol { 
> >  	SMB_PROTOCOL_NONE, 
> 
> Did this actually cause a compilation error?

No and yes, none I know of in mainline but with my uninlining tool, if 
that counts :-), it did until I work-around the number of compilation 
failures I got if I just include a single header file to a uninlined.c by 
taking an existing compilation unit's list of headers (and hoping for the 
best), which worked most of time (this case include). ...I'm not sure 
should they all be fixed or not (not to speak of how). Finding most of 
them seems relatively easy to automate by include alone + compile.


-- 
 i.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/