Re: [PATCH] smb.h: uses struct timespec but didn't includelinux/time.h

[Adrian Bunk]

On Tue, Apr 15, 2008 at 02:10:57AM -0700, Andrew Morton wrote:
> On Tue, 15 Apr 2008 12:04:04 +0300 (EEST) "Ilpo J__rvinen" <ilpo.jarvinen@xxxxxxxxxxx> wrote:
> 
> > 
> > Signed-off-by: Ilpo J__rvinen <ilpo.jarvinen@xxxxxxxxxxx>
> > ---
> >  include/linux/smb.h |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/include/linux/smb.h b/include/linux/smb.h
> > index f098dff..caa43b2 100644
> > --- a/include/linux/smb.h
> > +++ b/include/linux/smb.h
> > @@ -11,6 +11,7 @@
> >  
> >  #include <linux/types.h>
> >  #include <linux/magic.h>
> > +#include <linux/time.h>
> >  
> >  enum smb_protocol { 
> >  	SMB_PROTOCOL_NONE, 
> 
> Did this actually cause a compilation error?

Even if it doesn't at the moment it should be fixed - these kind
of issues are why often adding or removing an #include in a header 
suddenly breaks some configuration on some other architecture.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/