Re: [bisected] Latest git not seeing HD with sata_nv

[Roland Dreier]

 > It seems that commit 305d2a1a ("libata: unify mechanism to request
 > follow-up SRST") causes sata_nv not to see the HD on a system I have
 > here; with current git (80750147), I get this in my bootlog:

I wonder if this is related to the code

static int nv_hardreset(struct ata_link *link, unsigned int *class,
			unsigned long deadline)
{
	unsigned int dummy;

	/* SATA hardreset fails to retrieve proper device signature on
	 * some controllers.  Don't classify on hardreset.  For more
	 * info, see http://bugzilla.kernel.org/show_bug.cgi?id=3352
	 */
	return sata_sff_hardreset(link, &dummy, deadline);
}

It seems especially suspicious given that 305d2a1a touches
sata_sff_hardreset...

 - R.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/