Re: [PATCH] clocksource: Fix permissions for available_clocksource

[Thomas Gleixner]

On Fri, 2 May 2008, Heiko Carstens wrote:
> On Fri, May 02, 2008 at 04:36:37PM +0200, Thomas Gleixner wrote:
> > On Fri, 2 May 2008, Heiko Carstens wrote:
> > > From: Heiko Carstens <heiko.carstens@xxxxxxxxxx>
> > > 
> > > File permissions for
> > > /sys/devices/system/clocksource/clocksource0/available_clocksource
> > > are 600 which allows write access. But this is in fact a read only
> > > file. So change permissions to 400.
> > 
> > Indeed. The question is whether we should make this 444. There is no
> > harm, when users can read the info. Same applies for the
> > current_clocksource entry, making it 644 should be fine.
> 
> Sure, I can send an on-top patch for this.

Yes, please.
 
> Btw. did you recently try writing "jiffies" to current_clocksource?
> That seems to be a trick to stop the clock...

Hmm, that's after the kernel switched to highres and/or nohz, right ?
This came up earlier, but it got dropped from my to todo list. :(
Will have a look.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/