Re: [patch] fs: remove local variable copy of f_pos to enablethread-safe updates

[Al Viro]

On Fri, May 02, 2008 at 08:33:50AM -0700, Matti Linnanvuori wrote:

> File systems can be written so that implementations of read, lseek etc.
> acquire a lock before using *pos, which precludes races. That was the
> idea behind my patch. So, my patch does not necessarily cause races.
> read instances can be racy in Linux now because there is no lock to
> serialize read etc. system calls.

Oh, yes it does - current tree guarantees that variable passed to ->read()
will not change under it, so any code that relied on that got broken.

And no, modifying every driver's ->read() is not going to be fun - it's
not just filesystems.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/