Re: [POWERPC][v2] Bolt in SLB entry for kernel stack on secondarycpus
From: Benjamin Herrenschmidt
Date: Fri May 02 2008 - 19:20:22 EST
On Fri, 2008-05-02 at 19:03 +1000, Paul Mackerras wrote:
> David Gibson writes:
>
> > Do you even need the processor ID test at all? The boot processor
> > should always have its stack covered by SLB entry 0 when we come
> > through here, shouldn't it?
>
> I was concerned that get_paca()->kstack wouldn't have been initialized
> by the time the boot cpu calls slb_initialize(). If that fear is
> unfounded then the check could go.
No, you are correct, it's not initialized. However, I find that a bit
weird, as we shouldn't have a problem initializing it in
start_here_multiplatform rather than start_here_common.
The whole stack setup part of these here seems like a dup to me.
Ben.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/