Re: [PATCH 45/56] microblaze_v2: headers simple files - empty or redirect to asm-generic

[Grant Likely]

On Sun, May 4, 2008 at 8:34 PM, John Williams
<john.williams@xxxxxxxxxxxxx> wrote:
>
>  >  include/asm-microblaze/auxvec.h            |   14 ++++++++++++++
>  >  include/asm-microblaze/cputime.h           |   16 ++++++++++++++++
>  >  include/asm-microblaze/div64.h             |   16 ++++++++++++++++
>  >  include/asm-microblaze/emergency-restart.h |   16 ++++++++++++++++
>  >  include/asm-microblaze/errno.h             |   16 ++++++++++++++++
>  >  include/asm-microblaze/futex.h             |   16 ++++++++++++++++
>  >  include/asm-microblaze/kdebug.h            |   19 +++++++++++++++++++
>  >  include/asm-microblaze/local.h             |   16 ++++++++++++++++
>  >  include/asm-microblaze/mutex.h             |   16 ++++++++++++++++
>  >  include/asm-microblaze/namei.h             |   24 ++++++++++++++++++++++++
>  >  include/asm-microblaze/percpu.h            |   16 ++++++++++++++++
>  >  include/asm-microblaze/resource.h          |   16 ++++++++++++++++
>  >  include/asm-microblaze/user.h              |   18 ++++++++++++++++++
>
>  These are all just includes of asm-generic/* (hooray!).
>
>  But, is it reasonable to to suggest adding asm-generic at the end of the
>  kernel include path, and save all this verbosity?
>
>  Principle of least surprise maybe?

Convention in the other archs is already established to explicitly
include asm-generic files one by one.  It is probably best to match
existing convention for commonality sake.

Cheers,
g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/