Re: [PATCH 45/56] microblaze_v2: headers simple files - empty or redirect to asm-generic

From: Arnd Bergmann
Date: Tue May 06 2008 - 05:06:22 EST


On Monday 05 May 2008, Grant Likely wrote:
> >  These are all just includes of asm-generic/* (hooray!).
> >
> >  But, is it reasonable to to suggest adding asm-generic at the end of the
> >  kernel include path, and save all this verbosity?
> >
> >  Principle of least surprise maybe?
>
> Convention in the other archs is already established to explicitly
> include asm-generic files one by one.  It is probably best to match
> existing convention for commonality sake.

Right, I agree. We may eventually want to move to something more sophisticated,
but we should not change the current way of doing this while we're in the process
of adding a new architecture.

Arnd <><
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/