Re: [patch 4/4] x86: e820 unification: Extract common functions

[Adrian Bunk]

On Mon, May 05, 2008 at 12:02:17PM -0700, Christoph Lameter wrote:
> Extract the common functions to the common area. The parameters of
> e820_any_mapped vary between 32 and 64 bit. Convert them to unsigned long
> for 32 bit so that they match.
>...
> --- linux-2.6.orig/arch/x86/kernel/e820_32.c	2008-04-23 12:07:32.000000000 -0700
> +++ linux-2.6/arch/x86/kernel/e820_32.c	2008-05-05 12:00:01.000000000 -0700
> @@ -645,7 +645,7 @@ void __init limit_regions(unsigned long 
>   * with type.
>   */
>  int
> -e820_any_mapped(u64 start, u64 end, unsigned type)
> +e820_any_mapped(unsigned long start,unsigned long end, unsigned type)
>  {
>  	int i;
>  	for (i = 0; i < e820.nr_map; i++) {

This changes the parameters from 64bit to 32bit which looks fishy.

Are you sure the solution that would both match and be correct isn't to 
change the 64bit one to u64?

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/