Re: [patch 4/4] x86: e820 unification: Extract common functions

[Ingo Molnar]

* Adrian Bunk <bunk@xxxxxxxxxx> wrote:

> >  int
> > -e820_any_mapped(u64 start, u64 end, unsigned type)
> > +e820_any_mapped(unsigned long start,unsigned long end, unsigned type)
> >  {
> >  	int i;
> >  	for (i = 0; i < e820.nr_map; i++) {
> 
> This changes the parameters from 64bit to 32bit which looks fishy.

good catch! This could lead to bugs on 32-bit that has physical RAM 
addresses over 4GB.

> Are you sure the solution that would both match and be correct isn't 
> to change the 64bit one to u64?

agreed.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/