Re: [PATCH] x86: janitor work in bugs.c

From: Ingo Molnar
Date: Fri May 16 2008 - 09:49:28 EST



* Miklos Vajna <vmiklos@xxxxxxxxxxxxxx> wrote:

> -/* trap_init() enabled FXSR and company _before_ testing for FP problems here. */
> +/*
> + * trap_init() enabled FXSR and company _before_ testing for FP problems
> + * here.
> + */
> /* Test for the divl bug.. */
> __asm__("fninit\n\t"
> "fldl %1\n\t"

the two comments should be merged, somehow like this:

> + /*
> + * trap_init() enabled FXSR and company _before_ testing for FP
> + * problems here.
> + *
> + * Test for the divl bug:
> + */
> __asm__("fninit\n\t"

> check_popad();
> - init_utsname()->machine[1] = '0' + (boot_cpu_data.x86 > 6 ? 6 : boot_cpu_data.x86);
> + init_utsname()->machine[1] = '0' + (boot_cpu_data.x86 > 6 ? 6 :
> + boot_cpu_data.x86);

hm, that looks a bit ugly. It's nicer to have something like:

> + init_utsname()->machine[1] = '0' + (boot_cpu_data.x86 > 6 ? 6 :
> + boot_cpu_data.x86);

i.e. have a continuation of the right side of the expression, and have
it close to where it was broken from.

or just do:

> + init_utsname()->machine[1] =
> + '0' + (boot_cpu_data.x86 > 6 ? 6 : boot_cpu_data.x86);

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/