Re: [RFC PATCH] move link of vmlinux from Makefile to a script

[Jan Beulich]

>>> Sam Ravnborg <sam@xxxxxxxxxxxx> 18.05.08 20:52 >>>
>> 
>> I have several times been tempted to move it all to a shell script.
>> What has prevented me to do so has only been:
>> 1) that um has some subtle requirement and therefore redefine the
>>    vmlinux link
>> 2) that last time I reworked this stuff Andrew could not boot one
>>    of his systems and I never figured out why
>> 3) lack of time..
>> 
>> But if someone comes up with a patch that moves all this stuff out
>> of the top-level Makefile I am all open for it.
>
>I gave it a quick try. This is first try and comments are welcome.
>It does not address the um issue - but I think that is doable
>with an additional enviroment variable.
>
>The conditionals around KALLSYMS may be simplified - I just did
>not try to do so.

What I fail to see is how the multi-stage (necessary even without
CONFIG_KALLSYMS_EXTRA_PASS) kallsyms linking is now happening.

>What I like with the patch below is that it is 100 times more
>readable than the Makefile stuff.

Fully agree, and hence I'd favor this for .27 over the simple version
handling fix (which I'd hope to see in .26, and maybe even .25.x).

>The drawback are that we either link or not - we cannot restart
>from the middle of the link. But that it not a real issue.
>
>This patch futhermore remove a debug target to assist in
>kallysms issues - I have not seen it used for a long time
>now.

Is this what I referred to above? If so, I don't think these are just
debug targets...

>And I was also considering removing the extra kallsyms
>pass as I dunnot how usefull it is and for an allyesconfig
>build it take too much time.

I'd vote for it, but would of course think that whoever introduced it
should voice his opinion.

>This patch includes your version simplifactions too allthough
>that is not obvious.

Thanks, Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/