Re: [patch 07/22] fat: dont call notify_change

From: Miklos Szeredi
Date: Mon May 19 2008 - 03:48:05 EST


> > +EXPORT_SYMBOL_GPL(security_inode_setattr);
>
> Is there any particular reason you made it EXPORT_SYMBOL_GPL? It seems
> like this is replacing functionality that was previously exported
> without a GPL tag. I won't argue forcefully for changing it, but I
> did want to mention it on the list. I understand people wanting to
> make new functionality tagged that way (even though I disagree), but
> this doesn't seem to fit either the notion of an internal thing that
> shouldn't be touched or new functionality.

It's an internal thing: no other filesystem should do this (and IMO
even FAT should not, but some people seem to feel otherwise).

Miklos
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/