Re: [PATCH 0 of 2] fbcon: blinking text fix and implementation

[Pavel Machek]

On Tue 2008-07-01 16:38:07, Stefano Stabellini wrote:
> Hi all,
> I have recently found out that there is a small bug in fbcon handling
> the background color.
> The forth bit of the background color is the blink property bit, not the
> intensity bit, as for the foreground color.
> Therefore it shouldn't be included in the background color.
> I also wrote a very simple implementation for blinking text in fbcon,
> using the flashcursor function to scan the buffer for blinking chars.
> Any suggestion or critic is very welcome, but don't be too hard :)

I'd prefer to call that 'feature' and leave it alone. Burning cpu
power to provide annoying blinking text is at least questionable...

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/