Re: [PATCH 0 of 2] fbcon: blinking text fix and implementation

From: Stefano Stabellini
Date: Wed Jul 09 2008 - 11:22:03 EST


Pavel Machek wrote:

> I'd prefer to call that 'feature' and leave it alone. Burning cpu
> power to provide annoying blinking text is at least questionable...
>


I knew someone would have replied something like this, sooner or later;
this is why I sent two patches instead of just one.
The first one is a bugfix, the second one is the implementation of a
feature that some are not really missing.

Anyway, I am not burning so much cpu power: I have implemented a very
simple flag mechanism to scan the screen only when blinking text is
added to the screen or if we are scrolling.
The screen buffer is not so big, but if you are so concerned about
performances, I can implement a more efficient way to know whether we
need to scan the screen or not...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/