Re: [x86, patch] turn x86 VISWS into a generic architecture

[Robert Richter]

On 11.07.08 02:01:29, Yinghai Lu wrote:
> On Fri, Jul 11, 2008 at 1:54 AM, Ingo Molnar <mingo@xxxxxxx> wrote:
> >
> > * Robert Richter <robert.richter@xxxxxxx> wrote:
> >
> >> On 10.07.08 19:07:12, Ingo Molnar wrote:
> >>
> >> [...]
> >>
> >> > diff --git a/arch/x86/pci/Makefile b/arch/x86/pci/Makefile
> >> > index 99d9f09..e515e8d 100644
> >> > --- a/arch/x86/pci/Makefile
> >> > +++ b/arch/x86/pci/Makefile
> >> > @@ -9,9 +9,7 @@ pci-y                               := fixup.o
> >> >  pci-$(CONFIG_ACPI)         += acpi.o
> >> >  pci-y                              += legacy.o irq.o
> >> >
> >> > -# Careful: VISWS overrule the pci-y above. The colons are
> >> > -# therefor correct. This needs a proper fix by distangling the code.
> >> > -pci-$(CONFIG_X86_VISWS)            := visws.o fixup.o
> >> > +pci-$(CONFIG_X86_VISWS)            += visws.o
> >>
> >> Ingo, if we turn this into generic code, we have to remove the
> >> subsys_initcall for this too. Otherwise subsystem initialization is
> >> running twice, in legacy.c and in visws.c.
> >
> > Ok. Mind sending a patch for this against tip/master? Both your changes
> > and the visws cleanups are all in there and are tested through on
> > typical hardware.
> >
> > (Also, there's the suggestion from Yinghai to first do the numa init.)
> 
> could change the numa.c to numaq.c too. that name is confusing..

Ok, I will send out patches that cover all this and also pci-y
removal.

-Robert

-- 
Advanced Micro Devices, Inc.
Operating System Research Center
email: robert.richter@xxxxxxx

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/