Re: [PATCH] Fix netfilter xt_time's time_mt()'s use of do_div()

From: Patrick McHardy
Date: Tue Jul 15 2008 - 08:10:56 EST


Jan Engelhardt wrote:
On Tuesday 2008-07-15 13:43, Patrick McHardy wrote:

David Howells wrote:
Fix netfilter xt_time's time_mt()'s use of do_div() on an s64 by using
div_s64() instead.

This was introduced by patch ee4411a1b1e0b679c99686629b5eab5a072ce49f.
Alternatively we could use an u64 for the time. Jan, any preferences?

ktime_t and ktime_to_ns operate on signed quantities. I do not think we should be interpreting it as unsigned.

OK, I've applied David's patch. Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/