Re: [regression] nf_iterate(), BUG: unable to handle kernel NULL pointer dereference

[Herbert Xu]

On Thu, Jul 24, 2008 at 03:40:40PM +0300, Pekka Enberg wrote:
>
> Using ksize() for skbs will crash your kernel for some configurations
> because calling that function for memory allocated with
> kmem_cache_alloc() is not supported by all the allocators (well,
> SLOB).

So how about fixing the interface so that it can return an error
to indicate that the allocator doesn't support it? You're taking
away an entire interface just because an underlying implementation
that's used by a very small proportion of users doesn't do the
right thing.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/