Re: [PATCH] FILESYSTEMS: Make "advanced partitions" immediatelyunselectable.

From: Calvin Walton
Date: Sun Jul 27 2008 - 23:11:43 EST


On Sat, 2008-07-26 at 17:52 -0400, Robert P. J. Day wrote:
> On Sat, 26 Jul 2008, Randy Dunlap wrote:
>
> > On Sat, 26 Jul 2008 09:20:49 -0400 (EDT) Robert P. J. Day wrote:
> >
> > >
> > > Use "menuconfig" to allow all advanced partitions to be deselectable
> > > from the top-level FS menu.
> > >
> > > Signed-off-by: Robert P. J. Day <rpjday@xxxxxxxxxxxxxx>
> >
> > Hi,
> >
> > I like the idea, but it does have one problem. Before this patch,
> > if someone disabled PARTITION_ADVANCED, the .config would still
> > contain CONFIG_MSDOS_PARTITION=y but after this change, that config
> > line is missing. Not good.
>
> ah, quite right. the obvious solution is to move MSDOS_PARTITION out
> of there since it doesn't even *remotely* qualify as an "advanced"
> partition -- it's about as basic as it gets. i'll ponder and
> resubmit.

It's not that any of the partition types in the menu are advanced - it's
that the menu lets an "advanced" user add or remove support for
partitions types that are not native to their platform. This is so
someone can, say, mount a sparc scsi disk on an x86 box.

--
Calvin Walton <calvin.walton@xxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/