Re: [PATCH] FILESYSTEMS: Make "advanced partitions" immediatelyunselectable.

[Robert P. J. Day]

On Sun, 27 Jul 2008, Calvin Walton wrote:

> On Sat, 2008-07-26 at 17:52 -0400, Robert P. J. Day wrote:
> > On Sat, 26 Jul 2008, Randy Dunlap wrote:
> >
> > > On Sat, 26 Jul 2008 09:20:49 -0400 (EDT) Robert P. J. Day wrote:
> > >
> > > >
> > > > Use "menuconfig" to allow all advanced partitions to be
> > > > deselectable from the top-level FS menu.
> > > >
> > > > Signed-off-by: Robert P. J. Day <rpjday@xxxxxxxxxxxxxx>
> > >
> > > Hi,
> > >
> > > I like the idea, but it does have one problem.  Before this
> > > patch, if someone disabled PARTITION_ADVANCED, the .config would
> > > still contain CONFIG_MSDOS_PARTITION=y but after this change,
> > > that config line is missing.  Not good.
> >
> > ah, quite right.  the obvious solution is to move MSDOS_PARTITION
> > out of there since it doesn't even *remotely* qualify as an
> > "advanced" partition -- it's about as basic as it gets.  i'll
> > ponder and resubmit.
>
> It's not that any of the partition types in the menu are advanced -
...

but that's how it's **listed** in "make menuconfig".  once you click
on

  Partition Types  --->

the top-level config option that selects or deselects all of that menu
is labelled:

  [*] Advanced partition selection
      ^^^^^^^^

there's a logical inconsistency in that part of the menu -- are those
just regular partitions, or are they "advanced" partitions?  pick one.

  i'm not sure there's an elegant redesign for that -- an obvious fix
(if it's even worth doing) is to move the fundamental MSDOS partition
option out of there since it's not an "advanced" option.  and that
MSDOS option doesn't even really belong there anyway since, even if
you deselect that entire submenu, you still get CONFIG_MSDOS_PARTITION
selected in your eventual .config file.

  yes, it's nitpicking but, as it's laid out right now, it's
unnecessarily confusing and inconsistent.  but i don't know if there's
a trivial fix for it.

rday
--

========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
    Have classroom, will lecture.

http://crashcourse.ca                          Waterloo, Ontario, CANADA
========================================================================
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/