Re: [PATCH 05/10] ldisc: new dcd_change() method for linedisciplines.

From: Alan Cox
Date: Wed Aug 20 2008 - 06:29:34 EST


O> #ifdef CONFIG_PPS_IRQ_EVENTS
> ts = pps_irq_ts[port->irq];
> #else

That bit won't work very shortly - IRQ numbers are going sparse not a
single simple NR_IRQ array.

> This completely hides the (dirty) trick to the PPS clients and allow
> using struct tty_struct as first parameter.

Can we get the basics right first - drop the IRQ_EVENTS and HARDPPS
hackery out of the patchset and the core code then looks quite clean.
After that is sorted/merged we can come back to working out the best way
to improve the IRQ and HARDPPS hacks.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/