Re: [PATCH 05/10] ldisc: new dcd_change() method for linedisciplines.

From: Rodolfo Giometti
Date: Wed Aug 20 2008 - 09:02:05 EST


On Wed, Aug 20, 2008 at 11:11:17AM +0100, Alan Cox wrote:

> Can we get the basics right first - drop the IRQ_EVENTS and HARDPPS
> hackery out of the patchset and the core code then looks quite clean.
> After that is sorted/merged we can come back to working out the best way
> to improve the IRQ and HARDPPS hacks.

On Wed, Aug 20, 2008 at 12:31:15PM +0200, Ingo Molnar wrote:

> hm, NACK on this line of approach. If then this instrumentation should
> be done at the genirq level (kernel/irq/*.c). Also, the #ifdefs are ugly
> - please hide them in include files.

Ok, I'll propose a new patch set without the IRQ_EVENTS part (or with
this support as last patch to be easily discarted) to get kernel
inclusion, but we had to solve this issue soon since without this
trick the PPS precision is quite low.

Thanks,

Rodolfo

--

GNU/Linux Solutions e-mail: giometti@xxxxxxxxxxxx
Linux Device Driver giometti@xxxxxxxx
Embedded Systems phone: +39 349 2432127
UNIX programming skype: rodolfo.giometti
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/