Re: VolanoMark regression with 2.6.27-rc1

From: Ingo Molnar
Date: Thu Aug 21 2008 - 02:20:41 EST



* Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:

> Ok, people pointed out I got my promotion rules mixed up, I casted the
> result of the division to signed, instead of ending up with a signed
> division.
>
> #define avg(x, y) ({ \
> typeof(x) _avg1 = (x); \
> typeof(y) _avg2 = (y); \
> (void) (&_avg1 == &_avg2); \
> (typeof(x))(_avg1 + ((long long)_avg2 - _avg1)/2); })

ok, could you please just send a patch that is local to sched.c and then
we can let this kernel.h change play out independently? There's too many
iterations of this and it's better to decouple the two.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/