Re: [PATCH] Move sysctl check into debugging section and don't make it default y

[Eric W. Biederman]

"Andi Kleen" <andi@xxxxxxxxxxxxxx> writes:

> From: Andi Kleen <ak@xxxxxxxxxxxxxxx>
>
> I noticed that sysctl_check.o was the largest object file in
> a allnoconfig build in kernel/*.
>
>   36243       0       0   36243    8d93 kernel/sysctl_check.o
>
> This is because it was default y and && EMBEDDED. But I don't
> really see a need for a non kernel developer to have their
> sysctls checked all the time.

What is a feature change like this doing coming in after the
merge window?

Why doesn't an allnoconfig disable sysctl all together?

> So move the Kconfig into the kernel debugging section and
> also drop the default y and the EMBEDDED check.

Which is an idiotic thing to do.

These are the only checks we have against someone doing something
nasty in the sysctl hierarchy.   We have proven that we don't
have the discipline to do the right thing with code in the
core kernel.  I expect out of tree code will be much worse.

Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/