Re: [PATCH v3] usb: add Freescale QE/CPM USB peripheral controller driver

[Li Yang]

On Tue, Sep 2, 2008 at 8:01 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> On Tuesday 02 September 2008, Li Yang wrote:
>> Some of Freescale SoC chips have a QE or CPM co-processor which
>> supports full speed USB.  The driver adds device mode support
>> of both QE and CPM USB controller to Linux USB gadget.  The
>> driver is tested with MPC8360 and MPC8272, and should work with
>> other models having QE/CPM given minor tweaks.
>>
>> Signed-off-by: Xie Xiaobo <X.Xie@xxxxxxxxxxxxx>
>> Signed-off-by: Li Yang <leoli@xxxxxxxxxxxxx>
>
> Acked-by: Arnd Bergmann <arnd@xxxxxxxx>
>
> All my previous review comments have been addressed.
>
>> +     udc_controller->soc_type = (unsigned long)np->data;
>
> I'm not sure about this line, shouldn't that be
>        udc_controller->soc_type = (unsigned long)match->data; ?

Oops.  You are right.

- Leo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/