Re: [PATCH git latest] drivers/net: fixing a datarace related to update_stats()

From: Tammy
Date: Fri Sep 26 2008 - 12:06:36 EST


> You need two braces...
>
> - if ((inw(ioaddr+EL3_STATUS) & 0xe000) == 0x2000)
> + if ((inw(ioaddr+EL3_STATUS) & 0xe000) == 0x2000) {
> + spin_lock_irqsave(&lp->lock, flags);
> update_stats(dev);
> + spin_unlock_irqrestore(&lp->lock, flags);
> + }
> }
>


Thanks a lot. I will resubmit the patch then.

Lin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/