Re: [PATCH 4/6 v3] PCI: support SR-IOV capability

[Zhao, Yu]

Alex Chiang wrote:
> Do you want to emit a kobject_uevent here after success?
>
> Alternatively, have you investigated making these virtual
> functions into real struct device's? You get a lot of sysfs stuff
> for free if you do so, including correct place in sysfs hierarchy
> and uevents, etc.

The virtual functions are rpresented by 'struct pci_dev', so same as 
real device, the standard sysfs entries are created by pci_bus_add_device.

> My major complaints from last round (more documentation,
> shouldn't be a PCI hotplug driver) have been addressed. I'll let
> others comment about the other parts of your patch series.

Thanks, Alex.

> Thanks.
>
> /ac

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/