Re: [PATCH] HPET: Remove spurious HPET busy warning message.

From: Ingo Molnar
Date: Fri Oct 10 2008 - 03:27:15 EST



* David John <davidjon@xxxxxxxxxxx> wrote:

> On x86 systems with CONFIG_HPET_TIMER enabled, when
> the HPET driver (drivers/char/hpet.c) is loaded,
> an incorrect busy message is printed when the driver
> initializes since the HPET has already been allocated
> by the core timer code. Remove the warning message.
>
> Signed-off-by: David John <davidjon@xxxxxxxxxxx>
> Acked-by: Venkatesh Pallipadi <venkatesh.pallipadi@xxxxxxxxx>
> ---
> drivers/char/hpet.c | 4 ----
> 1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/char/hpet.c b/drivers/char/hpet.c
> index b3f5dbc..454c13b 100644
> --- a/drivers/char/hpet.c
> +++ b/drivers/char/hpet.c
> @@ -874,8 +874,6 @@ static acpi_status hpet_resources(struct acpi_resource *res, void *data)
> hdp->hd_address = ioremap(addr.minimum, addr.address_length);
>
> if (hpet_is_known(hdp)) {
> - printk(KERN_DEBUG "%s: 0x%lx is busy\n",
> - __func__, hdp->hd_phys_address);
> iounmap(hdp->hd_address);
> return AE_ALREADY_EXISTS;
> }
> @@ -891,8 +889,6 @@ static acpi_status hpet_resources(struct acpi_resource *res, void *data)
> HPET_RANGE_SIZE);
>
> if (hpet_is_known(hdp)) {
> - printk(KERN_DEBUG "%s: 0x%lx is busy\n",
> - __func__, hdp->hd_phys_address);
> iounmap(hdp->hd_address);
> return AE_ALREADY_EXISTS;
> }

applied to tip/timers/hpet, thanks John!

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/